Skip to content

chore: merge design-audit remediation to main with CI fixes#790

Closed
BigSimmo wants to merge 9 commits into
mainfrom
cursor/design-audit-merge-db17
Closed

chore: merge design-audit remediation to main with CI fixes#790
BigSimmo wants to merge 9 commits into
mainfrom
cursor/design-audit-merge-db17

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 17, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Finalizes the 2026-07-17 design/accessibility remediation against current main.
  • Fixes Playwright config TypeScript error (reducedMotion belongs in contextOptions) and restores stale regression test expectations that diverged from current source fixtures.
  • Supersedes chore: merge design-audit remediation to main #781.

Verification

  • Typecheck fix for playwright.config.ts validated locally.
  • UI verification not run: hosted CI UI gate required after the config/test resets.
  • Verification not run: full verify:pr-local deferred to hosted CI in this babysit pass.

Risk and rollout

  • Risk: medium; UI/accessibility surfaces and regression coverage change; includes migration/lockfile alignment that operators must apply carefully.
  • Rollback: revert this PR if user-facing or source-display regressions appear after deployment.
  • Provider or production effects: None beyond standard migration apply if included.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed
Open in Web Open in Cursor 

BigSimmo and others added 2 commits July 18, 2026 04:16
@BigSimmo
chore: merge design-audit remediation changes
d350d58
@cursoragent
fix: revert stale regression test expectations and remove invalid red…
819cae0 
…ucedMotion placement

- Remove reducedMotion from chromium project use block (TypeScript error; contextOptions already sets this globally)
- Revert audit-navigation-auth-regressions.test.ts to main markers (PR 781 introduced markers that don't exist in ClinicalDashboard.tsx)
- Revert audit-content-services-regressions.test.ts to main expectations (form source data matches Medium/Source-checked, not Unknown/Local-confirmation)
@supabase

supabase Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy due to reaching the limit of concurrent preview branches.
Go to Project Integrations Settings ↗︎ if you wish to update this limit.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@cursor
cursor Bot enabled auto-merge (squash) July 17, 2026 20:36
@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b3e56ff-5092-48ce-afe1-446430742605

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff8095 and def4c07.

📒 Files selected for processing (6)
  • src/components/clinical-dashboard/master-search-header.tsx
  • src/components/forms/forms-home-page.tsx
  • src/components/services/services-navigator-page.tsx
  • tests/ui-accessibility.spec.ts
  • tests/ui-smoke.spec.ts
  • tests/ui-tools.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/design-audit-merge-db17

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3107 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@cursoragent
fix(ci): restore main infra overwritten by design-audit merge
761a8a4 
The design-audit merge rewrote site-map generation, RAG, schema/drift,
and dropped the PwaLifecycle import, which broke lint/typecheck/unit CI.
Restore those surfaces from main, drop stale duplicate migrations, and
remove the services RightRail remount key rejected by audit regressions.
@cursoragent
merge: sync origin/main (#774 abort streams)
b609d81
@cursoragent
fix(ci): restore Home searchParams typing and services metric imports
1f9b67c 
Keep q/focus/run on the home route props and import service navigator
metric helpers so the design-audit UI changes typecheck again.
@cursoragent
Merge remote-tracking branch 'origin/main' into cursor/design-audit-m…
d1d796b 
…erge-db17
@cursoragent
Merge remote-tracking branch 'origin/main' into cursor/design-audit-m…
e6bd443 
…erge-db17
@cursoragent
Merge remote-tracking branch 'origin/main' into cursor/design-audit-m…
def4c07 
…erge-db17
@BigSimmo BigSimmo mentioned this pull request Jul 18, 2026
Merged
11 tasks
@BigSimmo BigSimmo closed this Jul 18, 2026
auto-merge was automatically disabled July 18, 2026 06:22

Pull request was closed

@BigSimmo BigSimmo mentioned this pull request Jul 18, 2026
Merged
8 tasks
@BigSimmo
BigSimmo deleted the cursor/design-audit-merge-db17 branch July 18, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo @cursoragent